From 047e03a40ac3b07918b902c105b0effb38b7a291 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Patrick=20L=C3=BChne?= <patrick@luehne.de>
Date: Tue, 26 May 2020 03:22:16 +0200
Subject: [PATCH] Update to-do notes

---
 github-fast-env.rb  | 0
 github-fast-envd.rb | 3 +--
 2 files changed, 1 insertion(+), 2 deletions(-)
 mode change 100755 => 100644 github-fast-env.rb
 mode change 100755 => 100644 github-fast-envd.rb

diff --git a/github-fast-env.rb b/github-fast-env.rb
old mode 100755
new mode 100644
diff --git a/github-fast-envd.rb b/github-fast-envd.rb
old mode 100755
new mode 100644
index 80e9367..d69c190
--- a/github-fast-envd.rb
+++ b/github-fast-envd.rb
@@ -92,6 +92,7 @@ def set_up_named_pipes(control_socket, connection_id)
 	stdout = open_pipe("#{pipe_base_path}.stdout")
 	stderr = open_pipe("#{pipe_base_path}.stderr")
 
+	# TODO: support script arguments
 	control_socket.puts "named-pipes #{pipe_base_path_encoded}"
 
 	stdin = File.open(stdin, "r")
@@ -200,10 +201,8 @@ while true
 					raise ClientScriptError.new error
 				end
 			rescue ClientScriptError => error
-				# TODO: Restore pipes to make sure that syntax errors are caught
 				encoded_error_output = Base64.encode64(error.source.full_message).delete("\n")
 				$original_stderr.puts "  error executing script, ignoring request"
-				# TODO: if the begin/rescue blog has syntax errors, these go unnoticed
 				begin
 					control_socket.puts "script_error #{encoded_error_output}"
 				rescue